Adds an Attribute assertion to metric data test#3487
Merged
MadVikingGod merged 7 commits intoNov 29, 2022
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=======================================
+ Coverage 77.9% 78.0% +0.1%
=======================================
Files 165 165
Lines 11634 11755 +121
=======================================
+ Hits 9066 9179 +113
- Misses 2372 2380 +8
Partials 196 196
🚀 New features to boost your workflow:
|
hanyuancheung
approved these changes
Nov 23, 2022
Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
dmathieu
approved these changes
Nov 28, 2022
dashpole
added a commit
that referenced
this pull request
May 14, 2026
Fix #8299 Relevant upstream v1.41.0 release notes: > ### 🛑 Breaking changes 🛑 > > - `graphql`: Change `graphql.document` attribute requirement level from Recommended to Opt-In due to sensitive data, cardinality, and size concerns ([#2985](open-telemetry/semantic-conventions#2985)) > - `process`: Move process.executable to its own entity. ([#3535](open-telemetry/semantic-conventions#3535)) > - `process`: Update requirement levels for process attributes to ensure consistent identification and description across platforms. ([#864](open-telemetry/semantic-conventions#864)) > - `rpc`: Remove `client.address` and `client.port` attributes from RPC server spans. ([#3487](open-telemetry/semantic-conventions#3487), [#3488](open-telemetry/semantic-conventions#3488)) > > ### 💡 Enhancements 💡 > > - `Go`: Add opt-in go.memory.gc.pause.duration histogram metric. ([#3353](open-telemetry/semantic-conventions#3353)) > - `deployment`: Stabilize `deployment.environment.name` attribute. ([#3339](open-telemetry/semantic-conventions#3339)) > - `deployment`: Add enum values for `deployment.environment.name` attribute. ([#2910](open-telemetry/semantic-conventions#2910)) > - `go`: Add the go.cpu.time opt-in metric, and add go.cpu.detailed_state and go.memory.detailed_type attributes to CPU and memory metrics respectively with wildcard values. ([#3354](open-telemetry/semantic-conventions#3354)) > - `go`: Add the opt-in go.memory.gc.cycles metric. ([#3353](open-telemetry/semantic-conventions#3353)) > - `telemetry`: Promote `telemetry.distro.name` and `telemetry.distro.version` attributes to 'stable'. ([#3650](open-telemetry/semantic-conventions#3650)) This PR also: - fixes semconv migration generation to ignore unexported declarations when computing renames/removals - upgrades repo imports, depguard, docs, templates, and schema URL expectations to `go.opentelemetry.io/otel/semconv/v1.41.0` - adds missing generated-file headers to semconvkit templates and regenerates the affected `v1.41.0` files via `TAG="v1.41.0" make semconv-generate` --------- Co-authored-by: David Ashpole <dashpole@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve the immediate problem of #3435.
It creates a new Assert function that will check if the attributes on ALL DataPoints contain the Attributes provided.